Skip to content

docs: enable copy-to-clipboard - #241

Merged
kabiroberai merged 1 commit into
mainfrom
docc-annotations
Sep 3, 2026
Merged

docs: enable copy-to-clipboard#241
kabiroberai merged 1 commit into
mainfrom
docc-annotations

Conversation

@kabiroberai

@kabiroberai kabiroberai commented Sep 3, 2026

Copy link
Copy Markdown
Member

Ref swiftlang/swift-docc#1273

Could be a good idea to later add nocopy to some of the code blocks that aren't commands

@kabiroberai
kabiroberai merged commit 1c34649 into main Sep 3, 2026
8 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c0bba782b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Documentation/build.sh
fi

"$docc" "$command" xtool.docc \
--enable-experimental-code-block-annotations \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Gate the annotation flag on DocC support

When this script takes its Linux/no-xcrun path, the standalone DocC bundled with Swift 6.2.4 does not recognize this option: docc convert --help omits it from the feature flags, and running Documentation/build.sh now exits with Error: Unknown option '--enable-experimental-code-block-annotations' (status 64), while the parent version succeeds. Consequently, both make docs and make docs-preview are unusable on that supported toolchain; only pass the flag when the selected DocC advertises support, or use an option supported by the repository's toolchain.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant